Fix flowtrackd naming in schema map #23007
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyperlint-ai
bot
requested review from
a team,
angelampcosta and
soheiokamoto
as code owners
Contributor
|
This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:
|
![windsurf-bot[bot]](https://avatars.githubusercontent.com/in/1066231?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Other comments (2)
- src/content/docs/analytics/graphql-api/migration-guides/network-analytics-v2/schema-map.mdx (22-22) I believe this change might be introducing an error rather than fixing one. In Cloudflare's naming conventions, 'flowtrackd' is likely the correct term (short for 'flow tracking daemon') rather than 'flowtracked'. Please verify the correct naming with the product team before proceeding with this change.
- src/content/docs/analytics/graphql-api/migration-guides/network-analytics-v2/index.mdx (70-70) While this PR changes the inline example to use single quotes (`direction: 'ingress'`), the full GraphQL query example at the bottom of the file still uses double quotes for all string values. For consistency, either both examples should use single quotes or both should use double quotes.
💡 To request another review, post a new comment with "/windsurf-review".
| In this example, we are going to use the GraphQL Analytics API to query for Firewall Events over a specified time period. | ||
|
|
||
| The following API call will request Firewall Events over a one hour period, and output the requested fields. Be sure to replace `<CLOUDFLARE_ZONE_TAG>`, `<EMAIL>`, and `<API_TOKEN>`[^1] with your zone tag and API credentials, and adjust the `datetime_geg` and `datetime_leq` values to your liking. | ||
| The following API call will request Firewall Events over a one hour period, and output the requested fields. Be sure to replace `<Cloudflare_ZONE_TAG>`, `<EMAIL>`, and `<API_TOKEN>`[^1] with your zone tag and API credentials, and adjust the `datetime_geq` and `datetime_leq` values to your liking. |
Contributor
There was a problem hiding this comment.
Good catch fixing the parameter name from datetime_geg to datetime_geq. This correction is important as the incorrect parameter name would cause API queries to fail.
| 6. For **Starting Point**, choose \*Clone Public Git Repository\*\*.\*\*\* | ||
|
|
||
| 7. Enter the *cloudflare\_block* URL for the public Git repository `git://github.com/llooker/cloudflare_block.git`. | ||
| 7. Enter the *cloudflare\_block* URL for the public Git repository `git://github.com/looker/cloudflare_block.git`. |
Contributor
There was a problem hiding this comment.
Good catch updating the GitHub repository URL from 'llooker' to 'looker'. This ensures users are directed to the official Looker organization repository.
| <th>dosdNetworkAnalytics-AdaptiveGroups</th> | ||
| <th>dosdAttackAnalytics-Groups</th> | ||
| <th>flowtrackdNetworkAnalytics-AdaptiveGroups</th> | ||
| <code>flowtrackedNetworkAnalytics-AdaptiveGroups</code> |
Contributor
There was a problem hiding this comment.
This change not only modifies the name from 'flowtrackd' to 'flowtracked' (which may be incorrect), but also changes the HTML structure from a table header to a element. This will break the table formatting in the documentation.
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses several style guide violations, including incorrect spellings and casing issues, as well as non-standard quote usage. The changes ensure compliance with the style guide and improve the overall quality of the documentation.
schema-map.mdx)